fix: ScopingFragment2 declares RUNTIME_PLUGIN on the eclipse-plugin manifest (not runtime)#1382
Draft
joaodinissf wants to merge 2 commits into
Draft
Conversation
…nerator Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
…est, not the runtime manifest The block guarded on `getEclipsePlugin().getManifest() != null` added RUNTIME_PLUGIN to `getRuntime().getManifest()` — which already contains it (a no-op on a Set) — so generated UI plugins never declared the com.avaloq.tools.ddk.xtext dependency the block was meant to add. Every sibling generator fragment writes to eclipsePlugin.manifest in this block (FormatFragment2, ExportFragment2, BuilderIntegrationFragment2, CompareFragment2, ModelInferenceFragment2, CheckQuickfixProviderFragment2); ScopingFragment2 was the lone outlier. Latent for years because the current UI plugins do not reference com.avaloq.tools.ddk.xtext packages directly, so the omitted Require-Bundle never caused a resolution failure. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #1380 (the
scope.generatorXtend→Java migration). The fix branch is based on the migration branch, so until #1380 merges this PR's diff also shows the migration commit — it reduces to the single-line fix automatically once #1380 lands.ScopingFragment2.generate()guards ongetEclipsePlugin().getManifest() != nullbut addsRUNTIME_PLUGINtogetRuntime().getManifest()(already present → no-op), so generated UI plugins never getcom.avaloq.tools.ddk.xtextdeclared as a required bundle. All six sibling*Fragment2generators write toeclipsePlugin.manifestin this block; this alignsScopingFragment2with them.Latent — not an active break: current consumers don't reference
com.avaloq.tools.ddk.xtextpackages directly. Pre-existing on master; the migration faithfully preserved it, this corrects it.🤖 Generated with Claude Code